Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format conversion tools for post tuning datasets #514

Merged
merged 17 commits into from
Dec 26, 2024
Merged

Format conversion tools for post tuning datasets #514

merged 17 commits into from
Dec 26, 2024

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Dec 18, 2024 •
edited
Loading

Select Query-Response format as the intermediate format for Data-Juicer.

  • LLaMA-Factory ShareGPT <--> DJ
  • MS-Swift ShareGPT <--> DJ
  • Alpaca <--> DJ
  • Messages <--> DJ

@HYLcool HYLcool added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 18, 2024
@HYLcool HYLcool self-assigned this Dec 18, 2024
yxdyc
yxdyc reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prototype implementation LGTM. Later we may need to discuss some terminologies and improve the clarity of the docs.

@yxdyc yxdyc mentioned this pull request Dec 19, 2024
Closed
3 tasks
@yxdyc yxdyc linked an issue Dec 19, 2024 that may be closed by this pull request
sharegpt format support #488
Closed
3 tasks
@HYLcool HYLcool marked this pull request as ready for review December 24, 2024 03:18
@HYLcool HYLcool changed the title [WIP] format conversion tools for post tuning datasets Format conversion tools for post tuning datasets Dec 24, 2024
@HYLcool HYLcool added the dj:tools issues/PRs about specific tools label Dec 24, 2024
yxdyc
yxdyc approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plz double check my modifications on readme(s) before merging it into main.

@yxdyc yxdyc added the dj:dataset issues/PRs about the dj-dataset label Dec 26, 2024
@HYLcool HYLcool merged commit 1554138 into main Dec 26, 2024
3 checks passed
@HYLcool HYLcool deleted the feat/ft_format_conv_tools branch December 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@BeachWang BeachWang Awaiting requested review from BeachWang

@Cathy0908 Cathy0908 Awaiting requested review from Cathy0908

Assignees

@HYLcool HYLcool

Labels
dj:dataset issues/PRs about the dj-dataset dj:tools issues/PRs about specific tools documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sharegpt format support
2 participants
@HYLcool @yxdyc